-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf::hash_partition kernel launch error with decimal128 types #12863
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-23.04
from
davidwendt:bug-hashpartition-decimal128
Mar 7, 2023
Merged
Fix cudf::hash_partition kernel launch error with decimal128 types #12863
rapids-bot
merged 9 commits into
rapidsai:branch-23.04
from
davidwendt:bug-hashpartition-decimal128
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Something isn't working
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
labels
Feb 28, 2023
@revans2 @firestarman Could you test out this fix with the Spark testcase from #12852 ? |
@davidwendt This PR can fix #12852. Thanks a lot. |
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Mar 1, 2023
ttnghia
approved these changes
Mar 2, 2023
ttnghia
reviewed
Mar 2, 2023
divyegala
approved these changes
Mar 6, 2023
bdice
approved these changes
Mar 6, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
cudf::hash_partition
error when usingdecimal128
column types. The internal optimized path,copy_block_partitions
, uses shared-memory for copying fixed-width type column elements. Forint128_t
type, the shared-memory needed (~64KB) is larger than the maximum size (~48KB) allowed causing a kernel launch failure.The optimized path is now restricted to only fixed-width types
int64_t
and below. Theint128_t
column types will fall through to the gather-map pattern instead. Accommodating this type in the existing copy-block implementation would likely penalize the performance of the other fixed-width types. If the new implementation becomes insufficient, we could explore a special optimized path in the future for the single typeint128_t
.An existing gtest for fixed-point types was updated to include a
decimal128
column to catch this kind of error in the future.Closes #12852
Checklist