Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for replace-multi for long strings #12858

Merged
merged 29 commits into from
Mar 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3ea6400
Improve performance for replace-multi for long strings
davidwendt Feb 27, 2023
72195c3
Merge branch 'branch-23.04' into multi-replace
davidwendt Feb 27, 2023
11a704a
Merge branch 'branch-23.04' into multi-replace
davidwendt Feb 28, 2023
530faa9
fix copy-if by converting lambda to functor
davidwendt Feb 28, 2023
d7ec896
Merge branch 'branch-23.04' into multi-replace
davidwendt Feb 28, 2023
a38ac59
fix style check
davidwendt Feb 28, 2023
4761e4d
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 1, 2023
3bcbd4a
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 5, 2023
5413bbd
remove temporary gtest
davidwendt Mar 6, 2023
50b6338
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 6, 2023
aacf01d
Merge branch 'multi-replace' of github.com:davidwendt/cudf into multi…
davidwendt Mar 6, 2023
ed17d30
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 6, 2023
bfdfbfd
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 7, 2023
1042d7b
change memset to uninitialized_fill
davidwendt Mar 7, 2023
2f1c955
refactor detail function into two sub-functions
davidwendt Mar 7, 2023
6521bb1
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 7, 2023
a3c7cb8
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 8, 2023
7ce40ed
add comment about string lengths in gtest
davidwendt Mar 9, 2023
57b6e9f
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 9, 2023
6d2043f
fix replace-entire-string case
davidwendt Mar 9, 2023
5e4a586
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 9, 2023
34182fc
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 9, 2023
b8ca349
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 10, 2023
2333c5b
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 11, 2023
72a3ea7
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 13, 2023
7bc175a
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 14, 2023
f7f0b8a
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 15, 2023
242a56e
remove unneeded const
davidwendt Mar 16, 2023
e46c09d
Merge branch 'branch-23.04' into multi-replace
davidwendt Mar 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ add_library(
src/strings/regex/regex_program.cpp
src/strings/repeat_strings.cu
src/strings/replace/backref_re.cu
src/strings/replace/multi.cu
src/strings/replace/multi_re.cu
src/strings/replace/replace.cu
src/strings/replace/replace_re.cu
Expand Down
4 changes: 2 additions & 2 deletions cpp/benchmarks/string/replace.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022, NVIDIA CORPORATION.
* Copyright (c) 2021-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -69,7 +69,7 @@ static void generate_bench_args(benchmark::internal::Benchmark* b)
int const row_mult = 8;
int const min_rowlen = 1 << 5;
int const max_rowlen = 1 << 13;
int const len_mult = 4;
int const len_mult = 2;
hyperbolic2346 marked this conversation as resolved.
Show resolved Hide resolved
generate_string_bench_args(b, min_rows, max_rows, row_mult, min_rowlen, max_rowlen, len_mult);
}

Expand Down
Loading