[REVIEW] Fix a pytest to match libcudf error type #12855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
vyasr
approved these changes
Feb 27, 2023
galipremsagar
added
5 - Ready to Merge
vyasr
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Sorry I completely misread this PR on initial read, this change appears to be erroneous. The exception type should not have changed at any point. Is this failing for you locally? My guess is that your local build is out of date, specifically the pxd file used for exception handling (updating that alone would not have triggered a rebuild for you if you got it by merging latest 23.04 because pxd updates do not trigger Cython rebuilds).
|
Apologies for the confusion, this was a local build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently in #12426, we changed the runtime exceptions to more specific exceptions on user side. This PR fixes a leftover in pytests that matches with libcudf error type.
Checklist