Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Raise error when numeric_only=True for non-numeric Series #12843

Merged

Conversation

galipremsagar
Copy link
Contributor

Description

This PR raises an error when numeric_only=True for rank if the Series is of non-numeric dtype.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 24, 2023
@galipremsagar galipremsagar self-assigned this Feb 24, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner February 24, 2023 16:39
@galipremsagar galipremsagar requested review from wence- and removed request for a team February 24, 2023 16:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 24, 2023
@galipremsagar
Copy link
Contributor Author

rank related pytests:

(cudfdev) pgali@dt07:/nvme/0/pgali/cudf$ pytest python/cudf/cudf/tests/test_rank.py -n 4
/nvme/0/pgali/envs/cudfdev/lib/python3.10/site-packages/pytest_benchmark/logger.py:46: PytestBenchmarkWarning: Benchmarks are automatically disabled because xdist plugin is active.Benchmarks cannot be performed reliably in a parallelized environment.
  warner(PytestBenchmarkWarning(text))
============================================================================================= test session starts ==============================================================================================
platform linux -- Python 3.10.9, pytest-7.2.1, pluggy-1.0.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /nvme/0/pgali/cudf/python/cudf/cudf/tests, configfile: pytest.ini
plugins: anyio-3.6.2, benchmark-4.0.0, xdist-3.2.0, cov-4.0.0, hypothesis-6.68.2, cases-3.6.13
gw0 [501] / gw1 [501] / gw2 [501] / gw3 [501]
........................................................................................................................................................................................................ [ 39%]
......................................................................................................................................................................................................... [ 79%]
....................................................................................................                                                                                                     [100%]
============================================================================================= 501 passed in 5.78s ==============================================================================================


(cudfdev) pgali@dt07:/nvme/0/pgali/cudf$ conda list | grep "pandas"
pandas                    2.0.0rc0                 pypi_0    pypi

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 24, 2023
@galipremsagar galipremsagar merged commit d1b1ea8 into rapidsai:pandas_2.0_feature_branch Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants