Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate linter configs into pyproject.toml #12834

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Consolidate linter configs into pyproject.toml #12834

merged 7 commits into from
Feb 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 23, 2023

Description

This consolidation allows us to get rid of now unnecessary setup.cfg files (thanks to removing versioneer in #12741). It also allows us to move towards a fully pyproject.toml-driven build.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2023
@vyasr vyasr requested review from a team as code owners February 23, 2023 18:54
@vyasr vyasr self-assigned this Feb 23, 2023
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Feb 23, 2023
@vyasr vyasr requested a review from a team as a code owner February 23, 2023 19:19
@github-actions github-actions bot added the ci label Feb 23, 2023
ajschmidt8
ajschmidt8 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

davidwendt
davidwendt approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++ files changes which appear to be just spelling fixes.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 23, 2023

Approving C++ files changes which appear to be just spelling fixes.

That's right, I'm not sure why these weren't caught before.

wence-
wence- approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very minor quibble, but looks good, thanks!

.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit 77c2e03 into rapidsai:branch-23.04 Feb 24, 2023
@vyasr vyasr deleted the feat/linter_configs branch February 24, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@wence- wence- wence- approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @wence- @ajschmidt8 @davidwendt