Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Deprecate names & dtype in Index.copy #12825

Merged
merged 6 commits into from
Mar 6, 2023
Merged

[REVIEW] Deprecate names & dtype in Index.copy #12825

merged 6 commits into from
Mar 6, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR deprecates dtype in Index & MultiIndex.copy, and names in Index.copy.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 22, 2023
@galipremsagar galipremsagar self-assigned this Feb 22, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner February 22, 2023 18:34
@galipremsagar galipremsagar changed the title [REVIEW] Deprecated names & dtype in Index.copy [REVIEW] Deprecate names & dtype in Index.copy Feb 22, 2023
@galipremsagar galipremsagar mentioned this pull request Feb 22, 2023
Closed
vyasr
vyasr reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question about how we want to broadcast these deprecations going forward.

python/cudf/cudf/core/index.py Show resolved Hide resolved
@galipremsagar galipremsagar mentioned this pull request Mar 6, 2023
Merged
3 tasks
vyasr
vyasr approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 618194d into rapidsai:branch-23.04 Mar 6, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @vyasr