[REVIEW] Deprecate na_sentinel in factorize
#12817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
galipremsagar
added
improvement
shwina
reviewed
Feb 22, 2023
shwina
reviewed
Feb 22, 2023
shwina
reviewed
Feb 22, 2023
Comment on lines
1346
to
1355
| dtype = min_scalar_type( | ||
| max( | ||
| len(cats), | ||
| -1 | ||
| if isinstance(na_sentinel, cudf.Scalar) | ||
| and na_sentinel.value is cudf.NA | ||
| else na_sentinel, | ||
| ), | ||
| 8, | ||
| ) |
There was a problem hiding this comment.
I wonder if it's cleaner for internal methods like this to always accept a cudf.Scalar when a scalar is expected.
(in the same way that we moved towards internal methods always accepting a ColumnBase, rather than any column-like object).
@vyasr do you have any thoughts?
There was a problem hiding this comment.
I think that's a better idea too, switched to accept only cudf.Scalar's here.
There was a problem hiding this comment.
Yes, I would favor that approach.
mroeschke
reviewed
Feb 23, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
shwina
reviewed
Mar 6, 2023
shwina
approved these changes
Mar 6, 2023
galipremsagar
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
na_sentinelinfactorize.use_na_sentinelas an alternative.sortinfactorize.The above changes are required as part of enabling pandas 2.0 support.
Checklist