Make string methods return a Series with a useful Index #12814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shwina was this PR intentionally marked as draft? |
|
@vyasr - should be ready for review now |
galipremsagar
approved these changes
Mar 9, 2023
vyasr
approved these changes
Mar 9, 2023
| dtype: object | ||
| """ | ||
| result_col = libstrings.character_tokenize(self._column) | ||
| if isinstance(self._parent, cudf.Series): | ||
| return cudf.Series(result_col, name=self._parent.name) | ||
| lengths = self.len().fillna(0) |
There was a problem hiding this comment.
Is the fillna(0) matching pandas behavior? It looks like the test is constructing the expected output manually to be the same, so it's not clear if it's going to match pandas or if the test is just constructing the same as what this outputs.
There was a problem hiding this comment.
There is no Pandas behaviour (Pandas doesn't have a tokenize).
The fillna(0) is there because nulls are ignored during tokenization, corresponding to 0 rows in the result (and thus, length = 0).
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #12806
Many string methods like
character_ngramscurrently return aSerieswith the default index (RangeIndex). This PR makes it so that the index of the result corresponds to the index of the input.More specifically, this PR changes the index of the result of the following string methods:
character_ngramstokenizecharacter_tokenizeChecklist