Shuffling read into a sub function in parquet read #12809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperbolic2346
added
3 - Ready for Review
ttnghia
reviewed
Feb 21, 2023
ttnghia
reviewed
Feb 21, 2023
ttnghia
reviewed
Feb 21, 2023
|
Should this depend on #12808? |
ttnghia
reviewed
Feb 21, 2023
ttnghia
reviewed
Feb 22, 2023
| * @param row_groups_info vector of information about row groups to read | ||
| * @param num_rows Maximum number of rows to read | ||
| * @return pair of boolean indicating if compressed chunks were found and a vector of futures for | ||
| * read completion |
There was a problem hiding this comment.
Suggested change
| * read completion | |
| * read completion |
There was a problem hiding this comment.
I would like to push it out as well, but pre-commit did that format and changes it back to that.
ttnghia
reviewed
Feb 22, 2023
Co-authored-by: Nghia Truong <[email protected]>
ttnghia
approved these changes
Feb 22, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is the first step toward the pipelined parquet reader and moves the chunk creation and file reads into another function. Right now, the operation is the same, but this change will allow for smaller groups to be read at a time for pipelining.
Checklist
closes #12811