Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove specification of manual stage for check_style.sh script. #12803

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Feb 17, 2023

Description

Do not explicitly specify to run the "manual" stage when running pre-commits as part of the ci/check_style.sh script.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Do not explicitly specify to run the "manual" stage when running pre-commits as part of the ci/check_style.sh script.
@csadorf csadorf requested a review from a team as a code owner February 17, 2023 14:45
@github-actions github-actions bot added the ci label Feb 17, 2023
@csadorf
Copy link
Contributor Author

csadorf commented Feb 17, 2023

Pinging @vyasr who originally suggested this thange.

@csadorf csadorf changed the title Remove specification of manual stage for check_style.sh script. CI: Remove specification of manual stage for check_style.sh script. Feb 17, 2023
@vyasr vyasr added 3 - Ready for Review Ready for review by team tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up Simon!

@bdice
Copy link
Contributor

bdice commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit eb4da93 into rapidsai:branch-23.04 Feb 25, 2023
@csadorf csadorf deleted the ci-remove-manual-stage-spec-for-style-check-pre-commit-runs branch February 27, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants