Fix bug in all-null list due to join_list_elements special handling #12767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
bug
davidwendt
approved these changes
Feb 14, 2023
ttnghia
reviewed
Feb 15, 2023
ttnghia
approved these changes
Feb 15, 2023
bdice
approved these changes
Feb 15, 2023
| }(); | ||
| // nulls are replaced due to special handling of all-null lists as empty lists | ||
| // by join_list_elements | ||
| auto child_string = cudf::strings::detail::replace_nulls( |
There was a problem hiding this comment.
Non-blocker: I think I'd prefer this to be two separate lines. First the IIFE, then call cudf::strings::detail::replace_nulls. It's just pretty long and complicated to read. After 20 lines of code, I forget that we're computing a function argument.
There was a problem hiding this comment.
I used this to avoid the temporary. Updated.
ttnghia
reviewed
Feb 16, 2023
| @@ -431,7 +433,9 @@ struct column_to_strings_fn { | |||
| } else { | |||
| return cudf::type_dispatcher(child_view.type(), *this, child_view); | |||
| } | |||
| }(); | |||
| }; | |||
There was a problem hiding this comment.
It is not IIFE. It's written this way to avoid the temporary variable. It will help reduce peak memory.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All-null list is considered as empty list in
join_list_elements. So, nulls of children are replaced bynarepbefore passing tojoin_list_elementsAPI.Related #12766
Checklist