-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI methods for detecting and purging non-empty nulls from LIST and STRUCT #12742
Merged
rapids-bot
merged 19 commits into
rapidsai:branch-23.04
from
razajafri:SP-5430-non-empty
Feb 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0f72ac7
Added Jni methods for detecting and purging non-empty nulls
razajafri 2b29f3b
Merge remote-tracking branch 'origin/branch-23.04' into SP-5430-non-e…
razajafri 7abf384
fix formatting
razajafri 097a09a
addressed review comments
razajafri dac0b21
removed the unused native method
razajafri 9c1ecc0
Merge remote-tracking branch 'origin/branch-23.04' into SP-5430-non-e…
razajafri d9bd29a
reformatted
razajafri 0a77f17
reformat
razajafri a70910c
Merge remote-tracking branch 'origin/branch-23.04' into SP-5430-non-e…
razajafri faa5e76
Merge branch 'branch-23.04' into SP-5430-non-empty
razajafri 7cd46bd
Merge branch 'branch-23.04' into SP-5430-non-empty
razajafri 7378c6a
Merge branch 'branch-23.04' into SP-5430-non-empty
ttnghia 01688bb
Merge branch 'branch-23.04' into SP-5430-non-empty
razajafri 6b12700
Merge branch 'branch-23.04' into SP-5430-non-empty
ajschmidt8 2843bc8
Merge branch 'branch-23.04' into SP-5430-non-empty
razajafri fbb5e49
closing the vectors
razajafri 508b9e6
release local allocation
razajafri a8a1106
Return an Array of ColumnViews so they can be closed by the caller
razajafri b1f84cb
Merge branch 'branch-23.04' into SP-5430-non-empty
razajafri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this returned vector should be in this try block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the problem, the problem is that the
input
column will be closed while the view won't. Unfortunately my build env is completely ruined and I will have to spend time to fix it before I can proceed. Thanks for your quick reviews