Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of test cases in multibyte_split benchmark #12737

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Reduce the number of test cases in multibyte_split benchmark #12737

merged 2 commits into from
Feb 9, 2023

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Feb 8, 2023 •
edited
Loading

Closes #12675

This PR reduces the number of test cases in multibyte_split_bench from 720 to 36.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue tech debt non-breaking Non-breaking change labels Feb 8, 2023
@PointKernel PointKernel self-assigned this Feb 8, 2023
@PointKernel PointKernel requested a review from a team as a code owner February 8, 2023 22:17
@PointKernel PointKernel added the improvement Improvement / enhancement to an existing function label Feb 8, 2023
@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 0cab19a into rapidsai:branch-23.04 Feb 9, 2023
@PointKernel PointKernel deleted the simplify-multibyte-split-bench branch February 9, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Reduce number of benchmark conditions in multibyte_split
3 participants
@PointKernel @bdice @ttnghia