Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI switches to nested JSON reader #12732

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

res-life
Copy link
Contributor

@res-life res-life commented Feb 8, 2023

Signed-off-by: Chong Gao [email protected]

Description

JNI switches to nested JSON reader
closes NVIDIA/spark-rapids#7518

Note:
The new reader read 05/03/2001 as String, so I removed the timestamps in the test case testReadJSONBufferInferred

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@res-life res-life requested a review from revans2 February 8, 2023 09:46
@res-life res-life requested a review from a team as a code owner February 8, 2023 09:46
@github-actions github-actions bot added the Java Affects Java cuDF API. label Feb 8, 2023
@res-life res-life added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function labels Feb 8, 2023
@res-life res-life force-pushed the use-new-json-reader branch from b2a337c to 11f32fa Compare February 8, 2023 09:55
@res-life res-life changed the title Switch to nested JSON reader JNI switchs to nested JSON reader Feb 8, 2023
@res-life res-life changed the title JNI switchs to nested JSON reader JNI switches to nested JSON reader Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@8630e7c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 11f32fa differs from pull request most recent head 2d7481a. Consider uploading reports for the commit 2d7481a to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12732   +/-   ##
===============================================
  Coverage                ?   85.85%           
===============================================
  Files                   ?      158           
  Lines                   ?    25204           
  Branches                ?        0           
===============================================
  Hits                    ?    21638           
  Misses                  ?     3566           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@res-life res-life added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 13, 2023
@res-life
Copy link
Contributor Author

/merge

1 similar comment
@pxLi
Copy link
Member

pxLi commented Feb 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit bad94b9 into rapidsai:branch-23.04 Feb 13, 2023
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Switch to nested JSON reader
5 participants