Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing cudf::io::source_info to use cudf::host_span<std::byte> in a non-breaking form #12730

Merged
merged 16 commits into from
Feb 21, 2023
Merged

Changing cudf::io::source_info to use cudf::host_span<std::byte> in a non-breaking form #12730

merged 16 commits into from
Feb 21, 2023

Conversation

hyperbolic2346
Copy link
Contributor

Description

Closes #12576

This change converts cudf::io::source_info to take a host_span<std::byte const>. This version deprecates the original API, but leaves it intact to avoid breaking changes. After being deprecated for a few releases, they will be removed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hyperbolic2346 hyperbolic2346 added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue improvement Improvement / enhancement to an existing function labels Feb 8, 2023
@hyperbolic2346 hyperbolic2346 self-assigned this Feb 8, 2023
@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner February 8, 2023 01:03
@hyperbolic2346 hyperbolic2346 added the non-breaking Non-breaking change label Feb 8, 2023
vuule
vuule requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
Few suggestions, and a potential bug fix.

cpp/include/cudf/io/types.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/io/types.hpp Outdated Show resolved Hide resolved
cpp/src/io/utilities/datasource.cpp Show resolved Hide resolved
@hyperbolic2346 @vuule
Update cpp/include/cudf/io/types.hpp
ff25499 
Co-authored-by: Vukasin Milovanovic <[email protected]>
vuule
vuule requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more suggestions. Mostly making sure the new API is as applicable as desired.

cpp/include/cudf/io/types.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/io/types.hpp Show resolved Hide resolved
cpp/include/cudf/io/types.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/io/types.hpp Outdated Show resolved Hide resolved
vuule
vuule reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! Few more comments.

cpp/tests/io/parquet_test.cpp Outdated Show resolved Hide resolved
cpp/tests/io/parquet_test.cpp Show resolved Hide resolved
cpp/include/cudf/io/types.hpp Show resolved Hide resolved
@hyperbolic2346 hyperbolic2346 requested a review from vuule February 16, 2023 21:39
vuule
vuule approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@hyperbolic2346
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c2f0161 into rapidsai:branch-23.04 Feb 21, 2023
@hyperbolic2346 hyperbolic2346 deleted the mwilson/cuio_host_span branch February 21, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@vuule vuule vuule approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@hyperbolic2346 hyperbolic2346

Labels
3 - Ready for Review Ready for review by team cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace host_buffer with host_span<std::byte const>
3 participants
@hyperbolic2346 @ttnghia @vuule