Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvbench environment class for initializing RMM in benchmarks #12728

Merged
merged 12 commits into from
Feb 10, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Adds an environment class to initialize the RMM pool memory resource manager before running benchmarks through nvbench. This removes the need to initialize RMM on every benchmark call which improves benchmark run performance and fixes some GPU metrics gathering when run under nsys.

This requires a patch to the nvbench source to enable this feature and is part of the following pull request: NVIDIA/nvbench#123
The patch can be removed once the PR is merged and source available to the libcudf build.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2023
@davidwendt davidwendt self-assigned this Feb 7, 2023
@github-actions github-actions bot added the CMake CMake build issue label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@0cab19a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 3f47f2d differs from pull request most recent head b0335e3. Consider uploading reports for the commit b0335e3 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12728   +/-   ##
===============================================
  Coverage                ?   85.85%           
===============================================
  Files                   ?      158           
  Lines                   ?    25204           
  Branches                ?        0           
===============================================
  Hits                    ?    21638           
  Misses                  ?     3566           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt marked this pull request as ready for review February 8, 2023 00:45
@davidwendt davidwendt requested review from a team as code owners February 8, 2023 00:45
@vyasr
Copy link
Contributor

vyasr commented Feb 8, 2023

@davidwendt did you want to merge this PR and revert the patch once the nvbench PR is merged, or wait for the nvbench PR? I'm fine either way; I know that the dev cycle on nvbench PRs is slower than ours.

@davidwendt
Copy link
Contributor Author

@davidwendt did you want to merge this PR and revert the patch once the nvbench PR is merged, or wait for the nvbench PR? I'm fine either way; I know that the dev cycle on nvbench PRs is slower than ours.

I did not want to wait for the nvbench PR to be merged first.

Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this mean this PR depends on NVIDIA/nvbench#123? Look like that PR is ready to merge.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let’s try to note a “fixed in” version if we know what we might expect.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes lgtm

cpp/cmake/thirdparty/patches/nvbench_override.json Outdated Show resolved Hide resolved
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes are now great 👍

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2d7e79a into rapidsai:branch-23.04 Feb 10, 2023
@davidwendt davidwendt deleted the nvbench-global-setup branch February 10, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants