Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memcheck read error in compound segmented reduce #12722

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix memcheck read error in compound segmented reduce #12722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54bd06
Fix memcheck read error in compound segmented reduce
davidwendt Feb 7, 2023
a273538
Merge branch 'branch-23.04' into bug-compound-seg-red
davidwendt Feb 7, 2023
cd113c8
Merge branch 'branch-23.04' into bug-compound-seg-red
davidwendt Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/include/cudf/detail/segmented_reduction.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@ void segmented_reduce(InputIterator d_in,
size_type* d_valid_counts,
rmm::cuda_stream_view stream)
{
using OutputType = typename thrust::iterator_value<OutputIterator>::type;
using IntermediateType = typename thrust::iterator_value<InputIterator>::type;
auto num_segments = static_cast<size_type>(std::distance(d_offset_begin, d_offset_end));
auto const binary_op = op.get_binary_op();
using OutputType = typename thrust::iterator_value<OutputIterator>::type;
using IntermediateType = typename thrust::iterator_value<InputIterator>::type;
auto num_segments = static_cast<size_type>(std::distance(d_offset_begin, d_offset_end)) - 1;
auto const binary_op = op.get_binary_op();
auto const initial_value = op.template get_identity<IntermediateType>();

rmm::device_uvector<IntermediateType> intermediate_result{static_cast<std::size_t>(num_segments),
Expand Down