-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the seed argument for hash partition #12715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liangcai Li <[email protected]>
firestarman
added
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Java) Reviewer
and removed
Java
Affects Java cuDF API.
labels
Feb 7, 2023
firestarman
added
Java
Affects Java cuDF API.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Feb 7, 2023
Signed-off-by: Liangcai Li <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12715 +/- ##
===============================================
Coverage ? 85.81%
===============================================
Files ? 158
Lines ? 25154
Branches ? 0
===============================================
Hits ? 21587
Misses ? 3567
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jlowe
reviewed
Feb 7, 2023
ttnghia
reviewed
Feb 7, 2023
ttnghia
reviewed
Feb 7, 2023
Co-authored-by: Nghia Truong <[email protected]>
Co-authored-by: Nghia Truong <[email protected]>
Signed-off-by: Liangcai Li <[email protected]>
ttnghia
reviewed
Feb 8, 2023
ttnghia
approved these changes
Feb 8, 2023
Co-authored-by: Nghia Truong <[email protected]>
jlowe
approved these changes
Feb 8, 2023
firestarman
added
the
5 - Ready to Merge
Testing and reviews complete, ready to merge
label
Feb 9, 2023
/merge |
vyasr
added
4 - Needs Review
Waiting for reviewer to review or respond
and removed
4 - Needs cuDF (Java) Reviewer
labels
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
4 - Needs Review
Waiting for reviewer to review or respond
5 - Ready to Merge
Testing and reviews complete, ready to merge
improvement
Improvement / enhancement to an existing function
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liangcai Li [email protected]
Description
This PR is exposing the
seed
parameter for the JNI hash partition APIs to support customizing the hash algorithm seed.The existing tests should cover this change.
Checklist