Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the seed argument for hash partition #12715

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

firestarman
Copy link
Contributor

@firestarman firestarman commented Feb 7, 2023

Signed-off-by: Liangcai Li [email protected]

Description

This PR is exposing the seed parameter for the JNI hash partition APIs to support customizing the hash algorithm seed.

The existing tests should cover this change.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@firestarman firestarman requested a review from a team as a code owner February 7, 2023 05:51
@github-actions github-actions bot added the Java Affects Java cuDF API. label Feb 7, 2023
@firestarman firestarman added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Java) Reviewer and removed Java Affects Java cuDF API. labels Feb 7, 2023
@firestarman firestarman self-assigned this Feb 7, 2023
@firestarman firestarman added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2023
Signed-off-by: Liangcai Li <[email protected]>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@fea6288). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12715   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25154           
  Branches                ?        0           
===============================================
  Hits                    ?    21587           
  Misses                  ?     3567           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@firestarman firestarman added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 9, 2023
@firestarman
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 74efb79 into rapidsai:branch-23.04 Feb 9, 2023
@firestarman firestarman deleted the hash-seed branch February 9, 2023 02:20
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants