-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable stream identification library in CI #12714
Reenable stream identification library in CI #12714
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12714 +/- ##
===============================================
Coverage ? 85.81%
===============================================
Files ? 158
Lines ? 25154
Branches ? 0
===============================================
Hits ? 21587
Misses ? 3567
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…_libidentify_streams
…_libidentify_streams
5c598e0
to
9071a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me. I checked the CI logs and I think it looks correct.
Just curious how long this takes to run? |
This doesn't really add measureable overhead because I'm not running any new tests, I'm just running all of the existing tests with stream validation on. For reference, the conda-cpp-tests jobs take 7-10 minutes from what I see on other PRs, and that's the same in this PR. In the future if the tests change in such a way that we want to run both with and without, then yes we may want to reconsider so that we don't rerun tests multiple times per push just for stream validation. |
/merge |
Description
This PR reenables the preload library introduced for verifying stream usage in libcudf in #11875. This library was disabled during the GitHub Actions migration.
Checklist