Add `regex_program` strings splitting java APIs and tests #12713

cindyyuanjiang · 2023-02-06T23:46:22Z

Description

This PR adds split_re, rsplit_re, split_record_re, rsplit_record_re related regex_program java APIs and unit tests.
Part of work for NVIDIA/spark-rapids#7295.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

Signed-off-by: Cindy Jiang <[email protected]>

codecov · 2023-02-07T00:57:44Z

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@291c751). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@               Coverage Diff               @@
##             branch-23.04   #12713   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25153           
  Branches                ?        0           
===============================================
  Hits                    ?    21586           
  Misses                  ?     3567           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

java/src/main/java/ai/rapids/cudf/ColumnView.java

Signed-off-by: Cindy Jiang <[email protected]>

ttnghia · 2023-02-07T20:47:04Z

java/src/main/java/ai/rapids/cudf/ColumnView.java

+  /**
+   * Returns a list of columns by splitting each string using the specified regex program pattern.
+   * The number of rows in the output columns will be the same as the input column. Null entries
+   * are added for a row where split results have been exhausted. Null input entries result in


Suggested change

* are added for a row where split results have been exhausted. Null input entries result in

* are added for the rows where split results have been exhausted. Null input entries result in

ttnghia · 2023-02-07T20:48:53Z

java/src/main/java/ai/rapids/cudf/ColumnView.java

+  /**
+   * Returns a list of columns by splitting each string using the specified regex program pattern.
+   * The number of rows in the output columns will be the same as the input column. Null entries
+   * are added for a row where split results have been exhausted. Null input entries result in


Suggested change

* are added for a row where split results have been exhausted. Null input entries result in

* are added for the rows where split results have been exhausted. Null input entries result in

ttnghia · 2023-02-07T20:50:30Z

java/src/main/java/ai/rapids/cudf/ColumnView.java

-   * corresponding rows of the output columns.
+   * Returns a list of columns by splitting each string using the specified string literal
+   * delimiter. The number of rows in the output columns will be the same as the input column.
+   * Null entries are added for a row where split results have been exhausted. Null input entries


Suggested change

* Null entries are added for a row where split results have been exhausted. Null input entries

* Null entries are added for the rows where split results have been exhausted. Null input entries

ttnghia · 2023-02-07T20:50:42Z

java/src/main/java/ai/rapids/cudf/ColumnView.java

+  /**
+   * Returns a list of columns by splitting each string using the specified regular expression
+   * pattern. The number of rows in the output columns will be the same as the input column.
+   * Null entries are added for a row where split results have been exhausted. Null input entries


Suggested change

* Null entries are added for a row where split results have been exhausted. Null input entries

* Null entries are added for the rows where split results have been exhausted. Null input entries

ttnghia · 2023-02-07T20:53:28Z

java/src/main/native/src/ColumnViewJni.cpp

+    auto const column_view = reinterpret_cast<cudf::column_view const *>(input_handle);
+    auto const strings_column = cudf::strings_column_view{*column_view};


Suggest to avoid column_view name as it may clash with cudf::column_view.

Suggested change

auto const column_view = reinterpret_cast<cudf::column_view const *>(input_handle);

auto const strings_column = cudf::strings_column_view{*column_view};

auto const input = reinterpret_cast<cudf::column_view const *>(input_handle);

auto const strings_column = cudf::strings_column_view{*input};

ttnghia · 2023-02-07T20:53:44Z

java/src/main/native/src/ColumnViewJni.cpp

@@ -735,22 +754,43 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_stringSplitRecord(JNIEnv

  try {
    cudf::jni::auto_set_device(env);
-    auto const input = reinterpret_cast<cudf::column_view *>(input_handle);
-    auto const strs_input = cudf::strings_column_view{*input};
+    auto const column_view = reinterpret_cast<cudf::column_view const *>(input_handle);


Similar to above.

ttnghia · 2023-02-07T20:55:26Z

java/src/main/native/src/ColumnViewJni.cpp

+
+  try {
+    cudf::jni::auto_set_device(env);
+    auto const column_view = reinterpret_cast<cudf::column_view const *>(input_handle);


Similar to above.

Thank you! All changes updated.

Signed-off-by: Cindy Jiang <[email protected]>

cindyyuanjiang · 2023-02-08T01:15:25Z

/merge

cindyyuanjiang added 2 commits February 6, 2023 14:38

added splitting regex program apis and tests

ffc15c3

Signed-off-by: Cindy Jiang <[email protected]>

fixed code formatting

4718540

Signed-off-by: Cindy Jiang <[email protected]>

cindyyuanjiang mentioned this pull request Feb 6, 2023

[FEA] switch APIs to regex_program NVIDIA/spark-rapids#7295

Closed

github-actions bot added the Java Affects Java cuDF API. label Feb 6, 2023

cindyyuanjiang added feature request New feature or request non-breaking Non-breaking change labels Feb 6, 2023

Merge branch 'branch-23.04' into splitting-regex-program-apis

70fa951

jlowe reviewed Feb 7, 2023

View reviewed changes

java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved

cindyyuanjiang added 2 commits February 7, 2023 11:45

refactored stringSplit and stringSplitRecord native methods

0376ce0

Signed-off-by: Cindy Jiang <[email protected]>

fixed code formatting

5dd8f0f

Signed-off-by: Cindy Jiang <[email protected]>

cindyyuanjiang marked this pull request as ready for review February 7, 2023 20:06

cindyyuanjiang requested a review from a team as a code owner February 7, 2023 20:06

cindyyuanjiang added 2 commits February 7, 2023 12:12

removed incorrect stringsplit tests

3643269

Signed-off-by: Cindy Jiang <[email protected]>

fixed indentation

70de2b5

Signed-off-by: Cindy Jiang <[email protected]>

jlowe approved these changes Feb 7, 2023

View reviewed changes

ttnghia reviewed Feb 7, 2023

View reviewed changes

cindyyuanjiang and others added 2 commits February 7, 2023 14:05

fixed variable naming and comments

465ea42

Signed-off-by: Cindy Jiang <[email protected]>

Merge branch 'branch-23.04' into splitting-regex-program-apis

9a7c154

ttnghia approved these changes Feb 7, 2023

View reviewed changes

rapids-bot bot merged commit fea6288 into rapidsai:branch-23.04 Feb 8, 2023

cindyyuanjiang deleted the splitting-regex-program-apis branch February 8, 2023 01:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `regex_program` strings splitting java APIs and tests #12713

Add `regex_program` strings splitting java APIs and tests #12713

cindyyuanjiang commented Feb 6, 2023 •

edited

Loading

codecov bot commented Feb 7, 2023 •

edited

Loading

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

ttnghia Feb 7, 2023

cindyyuanjiang Feb 7, 2023

cindyyuanjiang commented Feb 8, 2023

	* are added for a row where split results have been exhausted. Null input entries result in
	* are added for the rows where split results have been exhausted. Null input entries result in

	* Null entries are added for a row where split results have been exhausted. Null input entries
	* Null entries are added for the rows where split results have been exhausted. Null input entries

		auto const column_view = reinterpret_cast<cudf::column_view const *>(input_handle);
		auto const strings_column = cudf::strings_column_view{*column_view};

Add regex_program strings splitting java APIs and tests #12713

Add regex_program strings splitting java APIs and tests #12713

Conversation

cindyyuanjiang commented Feb 6, 2023 • edited Loading

Description

Checklist

codecov bot commented Feb 7, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cindyyuanjiang commented Feb 8, 2023

Add `regex_program` strings splitting java APIs and tests #12713

Add `regex_program` strings splitting java APIs and tests #12713

cindyyuanjiang commented Feb 6, 2023 •

edited

Loading

codecov bot commented Feb 7, 2023 •

edited

Loading