Add regex_program strings replacing java APIs and tests
#12701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Jiang <[email protected]>
cindyyuanjiang
added
feature request
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12701 +/- ##
===============================================
Coverage ? 85.81%
===============================================
Files ? 158
Lines ? 25154
Branches ? 0
===============================================
Hits ? 21587
Misses ? 3567
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jlowe
approved these changes
Feb 7, 2023
ttnghia
reviewed
Feb 7, 2023
| cudf::jni::native_jstring pattern(env, j_pattern); | ||
| auto repl = reinterpret_cast<cudf::string_scalar const *>(j_repl); | ||
| return release_as_jlong(cudf::strings::replace_re(scv, pattern.get(), *repl, j_maxrepl)); | ||
| auto const column_view = reinterpret_cast<cudf::column_view const *>(j_column_view); |
There was a problem hiding this comment.
Similar to my comment on other PR, avoid to use column_view name. This also applies to below.
There was a problem hiding this comment.
Updated, thank you!
Signed-off-by: Cindy Jiang <[email protected]>
@jlowe Thank you! I am not sure I understand the nit. Do you mind elaborating a bit? |
…dyyuanjiang/cudf into replacing-regex-program-apis
jlowe
reviewed
Feb 7, 2023
Signed-off-by: Cindy Jiang <[email protected]>
ttnghia
approved these changes
Feb 7, 2023
jlowe
approved these changes
Feb 7, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cindy Jiang [email protected]
Description
This PR adds replace_re, replace_with_backrefs related
regex_programjava APIs and unit tests.Part of work for NVIDIA/spark-rapids#7295.
Checklist