-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex_program
searching APIs and related java classes
#12666
Add regex_program
searching APIs and related java classes
#12666
Conversation
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12666 +/- ##
===============================================
Coverage ? 85.81%
===============================================
Files ? 158
Lines ? 25151
Branches ? 0
===============================================
Hits ? 21584
Misses ? 3567
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new classes seem OK, but normally we do not add classes and APIs without the ability for the user to meaningfully wield it. There are no tests of these new APIs to prove they work and are useful, and there's nothing that can be meaningfully done with them as-is.
Should we at least add this API to some Table or ColumnView method to both provide a test surface for it and a meaningful way to start using it? We wouldn't have to put the new class in all potential places in one PR, but not putting it anywhere seems a bit less than ideal.
Is there a way to test this through the Spark test suite before merging so we can catch any potential errors like those found during the end of the last release? |
Yes, thank you. I will update to include some usage of the added classes. |
Yes, I will test the changes in the Spark plugin to avoid issues encountered before. Thanks! |
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
regex_program
searching APIs and related java classes
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
Signed-off-by: Cindy Jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Cindy Jiang [email protected]
Description
This PR adds contains_re, matches_re, count_re, findall related
regex_program
java APIs and unit tests, andRegexProgram
,RegexFlag
, andCaptureGroups
java classes to support theseregex_program
APIs.Part of work for NVIDIA/spark-rapids#7295.
Checklist