Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Merge
copy-on-write
feature branch intobranch-23.04
#12619[REVIEW] Merge
copy-on-write
feature branch intobranch-23.04
#12619Changes from 10 commits
bd72a17
2f529d3
bd6933f
1a758e6
fa094ed
a857ad9
173e749
5b54519
d46c3a8
ae95e48
ee78be8
a02a150
7c84343
1afd167
d3fd0f3
527a61f
b69c34d
761c328
6717caf
60d009f
39e59c9
be011b2
0cdec03
9791014
7cd8150
dde8d3a
2ac5d43
f474e79
8506339
dd1f1fa
5a8ad61
417883b
5470ee9
99967fc
45e1fd1
9077049
8e7240c
2e9eac7
26b1d87
a13040a
36ecf22
c3977b7
33f6d3b
0412db6
a74bb48
1a2ec7b
3c5ac1a
4ba71d3
6edd003
96401fa
dbaf0c3
518ea66
5ed99ad
6a96647
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I switch between CoW on and CoW off in the same run, or is this a one-time option I should set before I actually create and manipulate any cudf options? I suspect it is the latter. If so, we should call that out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the former. Pandas allows that too:
Since all of our buffer creation calls go through, the
as_buffer
constructor we are able to support COW on and off in the same run.