Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about CUB patch for SegmentedSortInt.Bool gtest #12611

Merged
merged 9 commits into from
Jan 30, 2023
Merged

Add comment about CUB patch for SegmentedSortInt.Bool gtest #12611

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
869f38c
Add comment about CUB patch for SegmentedSortInt.Bool gtest
davidwendt Jan 25, 2023
b5d737d
add missing article
davidwendt Jan 25, 2023
9ed8ca2
Merge branch 'branch-23.04' into comment-segmented-sort-bool
davidwendt Jan 25, 2023
3249177
Merge branch 'branch-23.04' into comment-segmented-sort-bool
davidwendt Jan 26, 2023
f5cd650
fix wording
davidwendt Jan 27, 2023
b567655
fix format
davidwendt Jan 27, 2023
74308ac
Merge branch 'branch-23.04' into comment-segmented-sort-bool
davidwendt Jan 27, 2023
32f329d
Merge branch 'branch-23.04' into comment-segmented-sort-bool
davidwendt Jan 30, 2023
1a47502
Merge branch 'branch-23.04' into comment-segmented-sort-bool
davidwendt Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/tests/sort/segmented_sort_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022, NVIDIA CORPORATION.
* Copyright (c) 2021-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -318,6 +318,8 @@ TEST_F(SegmentedSortInt, ErrorsMismatchArgSizes)
CUDF_EXPECT_NO_THROW(cudf::stable_segmented_sort_by_key(input1, input1, segments));
}

// Test specifically verifies the patch added in https://github.com/rapidsai/cudf/pull/12234
// This test will fail if the CUB bug fix is not available or the patch has not been applied.
TEST_F(SegmentedSortInt, Bool)
{
cudf::test::fixed_width_column_wrapper<bool> col1{
Expand Down