Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs build job #12592

Merged
merged 33 commits into from
Feb 23, 2023
Merged

Add docs build job #12592

merged 33 commits into from
Feb 23, 2023

Conversation

AyodeAwe
Copy link
Contributor

The PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

@github-actions github-actions bot added the ci label Jan 23, 2023
@AyodeAwe AyodeAwe added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ci labels Jan 23, 2023
@github-actions github-actions bot added the ci label Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@d077c9b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 1ba6877 differs from pull request most recent head 0fb251d. Consider uploading reports for the commit 0fb251d to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.04   #12592   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25153           
  Branches                ?        0           
===============================================
  Hits                    ?    21586           
  Misses                  ?     3567           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AyodeAwe AyodeAwe marked this pull request as ready for review January 29, 2023 15:55
@AyodeAwe AyodeAwe requested a review from a team as a code owner January 29, 2023 15:55
@AyodeAwe
Copy link
Contributor Author

Waiting for feedback regarding the java docs build from @bdice

@AyodeAwe AyodeAwe changed the title add docs_build step Add docs build job Jan 29, 2023
@AyodeAwe AyodeAwe changed the base branch from branch-23.02 to branch-23.04 February 2, 2023 11:22
@bdice bdice mentioned this pull request Feb 2, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 2, 2023
@bdice
Remove DataFrame.quantiles from docs. (#12684)
21ef256 
Removes documentation for `DataFrame.quantiles`, which was deprecated and then removed in #12281. This issue was discovered while building the docs in #12592.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #12684
This was referenced Feb 3, 2023
Closed
Closed
@AyodeAwe AyodeAwe mentioned this pull request Feb 6, 2023
Closed
ajschmidt8
ajschmidt8 reviewed Feb 13, 2023
View reviewed changes
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Feb 13, 2023

Waiting for feedback regarding the java docs build from @bdice

(Documenting conversation notes from Slack) I tried building Java docs locally a while ago with mvn build but I didn't figure it out. @GaryShen2008 may be able to help automate this.

@ajschmidt8
Copy link
Member

Waiting for feedback regarding the java docs build from @bdice

(Documenting conversation notes from Slack) I tried building Java docs locally a while ago with mvn build but I didn't figure it out. @GaryShen2008 may be able to help automate this.

We're going to defer the java docs builds to a future PR so we can get this merged.

AyodeAwe and others added 9 commits February 17, 2023 10:26
@AyodeAwe
skip docs nightly
09f19c1
@AyodeAwe
Merge branch 'add_docs_build' of github.com:AyodeAwe/cudf into add_do…
01f7bdb 
…cs_build
@ajschmidt8
Merge branch 'branch-23.04' into add_docs_build
b884367
@ajschmidt8
rm conf.py imports
70baa0f 
According to the [`autodoc` documentation](https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html), `autodoc` will automatically import the modules to be documented.

The CI docs building process will install the packages that were built in previous stages of the workflow and presumably `autodoc` will import those correctly, which means these lines are not needed.
@ajschmidt8
add generated file dirs to .gitignore
69ce9e8
@ajschmidt8
add dask-cudf to docs build installs
b0fb546
@ajschmidt8
rm unnecessary comments
9e4ffbb
@ajschmidt8
Merge remote-tracking branch 'upstream/branch-23.04' into add_docs_build
9ec7b7b
@ajschmidt8
update dependency list name
4898bca
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels Feb 20, 2023
bdice
bdice requested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for a typo fix in upload script. I’d like to investigate a couple other questions as well before merging.

ci/build_docs.sh Outdated Show resolved Hide resolved
ci/build_docs.sh Outdated Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
docs/cudf/source/conf.py Show resolved Hide resolved
@AyodeAwe
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5719463 into rapidsai:branch-23.04 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyodeAwe @bdice @ajschmidt8