Use kvikIO as the default IO backend #12574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
Codecov ReportBase: 86.58% // Head: 85.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12574 +/- ##
================================================
- Coverage 86.58% 85.71% -0.87%
================================================
Files 155 155
Lines 24368 24865 +497
================================================
+ Hits 21098 21312 +214
- Misses 3270 3553 +283
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
…ce_read()` (#12584) `datasource_chunk_reader.get_next_chunk()` called `device_read_async()` without waiting on the returned Future. Should fix the CI fail in #12574 cc. @vuule Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Vukasin Milovanovic (https://github.com/vuule) - Yunsong Wang (https://github.com/PointKernel) URL: #12584
…fea-kvikio-default
ttnghia
approved these changes
Jan 23, 2023
karthikeyann
approved these changes
Jan 23, 2023
ajschmidt8
reviewed
Jan 23, 2023
| @@ -167,13 +167,6 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then | |||
| echo "Running GoogleTest $test_name" | |||
| ${gt} --gtest_output=xml:"$WORKSPACE/test-results/" | |||
| done | |||
|
|
|||
There was a problem hiding this comment.
This file is no longer in use by CI since the switch to GitHub Actions.
the new CPP test file is here: https://github.com/rapidsai/cudf/blob/branch-23.02/ci/test_cpp.sh.
I imagine you may want to make similar changes there.
We will be removing all of the old Jenkins CI scripts from the RAPIDS repositories in the coming weeks.
ajschmidt8
approved these changes
Jan 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #10415
Switching the default backend to kvikIO.
Benchmarks show the same or better throughput.
Removing the redundant libcudf tests that ran with kvikIO.
Checklist