Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace exclusive_scan with sizes_to_offsets in cudf::lists::sequences #12541

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Rework cudf::lists::sequences to use the internal sizes_to_offsets utility instead of thrust::exclusive_scan for computing offsets. This allows the operation to throw an error if it the output would exceed the size limit of a column.

Reference #12167

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2023
@davidwendt davidwendt self-assigned this Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 85.67% // Head: 85.67% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (46fcd6b) compared to base (36b07f1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02   #12541      +/-   ##
================================================
- Coverage         85.67%   85.67%   -0.01%     
================================================
  Files               155      155              
  Lines             24818    24818              
================================================
- Hits              21264    21263       -1     
- Misses             3554     3555       +1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/categorical.py 89.46% <0.00%> (-0.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 17, 2023
@davidwendt davidwendt changed the title Replace exclusive-scan with sizes-to-offsets in cudf::lists::sequences Replace exclusive_scan with sizes_to_offsets in cudf::lists::sequences Jan 17, 2023
@davidwendt davidwendt marked this pull request as ready for review January 17, 2023 15:43
@davidwendt davidwendt requested a review from a team as a code owner January 17, 2023 15:43
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1726962 into rapidsai:branch-23.02 Jan 17, 2023
@davidwendt davidwendt deleted the rework-sequences-offsets branch January 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants