-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard CUDA runtime APIs with error checking #12531
Guard CUDA runtime APIs with error checking #12531
Conversation
Codecov ReportBase: 86.58% // Head: 85.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12531 +/- ##
================================================
- Coverage 86.58% 85.70% -0.88%
================================================
Files 155 155
Lines 24368 24865 +497
================================================
+ Hits 21098 21311 +213
- Misses 3270 3554 +284
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Wherever appropriate, I’d like to replace these raw cudaMemcpy calls with vector factories.
/merge |
Description
This PR adds missing error checking for CUDA runtime APIs in libcudf.
Checklist