Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute sanitizer in GitHub Actions CI #12530

Closed
wants to merge 2 commits into from
Closed

Fix compute sanitizer in GitHub Actions CI #12530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe9347
Add cuda-sanitizer-api.
bdice Jan 10, 2023
623a793
Catch exit codes in compute sanitizer.
bdice Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/test_cpp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2022, NVIDIA CORPORATION.
# Copyright (c) 2022-2023, NVIDIA CORPORATION.

set -euo pipefail

Expand Down Expand Up @@ -93,6 +93,11 @@ if [[ "${RAPIDS_BUILD_TYPE}" == "nightly" ]]; then
fi
echo "Running gtest $test_name"
${COMPUTE_SANITIZER_CMD} ${gt} | tee "${RAPIDS_TESTS_DIR}${test_name}.cs.log"
exitcode=$?
if (( ${exitcode} != 0 )); then
SUITEERROR=${exitcode}
echo "FAILED: GTest ${gt}"
fi
done
unset GTEST_CUDF_RMM_MODE
# TODO: test-results/*.cs.log are processed in gpuci
Expand Down
1 change: 1 addition & 0 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies:
- cmake>=3.23.1,!=3.25.0
- cubinlinker
- cuda-python>=11.7.1,<12.0
- cuda-sanitizer-api=11.8.86
- cudatoolkit=11.8
- cupy>=9.5.0,<12.0.0a0
- cxx-compiler
Expand Down
11 changes: 11 additions & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ files:
- notebooks
- py_version
- run
- test_cpp
- test_python
test_cpp:
output: none
includes:
- cudatoolkit
- libidentify_stream_usage_build
- test_cpp
test_python:
output: none
includes:
Expand Down Expand Up @@ -265,6 +267,15 @@ dependencies:
arch: aarch64
packages:
- cupy-cuda11x -f https://pip.cupy.dev/aarch64 # TODO: Verify that this works.
test_cpp:
specific:
- output_types: conda
matrices:
- matrix:
cuda: "11.8"
packages:
# Needed for compute-sanitizer --tool memcheck
- cuda-sanitizer-api=11.8.86
test_java:
common:
- output_types: conda
Expand Down