Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xfail incompatibilities #12423

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 19, 2022

Description

There are some minor violations of the new xfail_strict policy that were merged without accounting for that change.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 19, 2022
@vyasr vyasr self-assigned this Dec 19, 2022
@vyasr vyasr requested a review from a team as a code owner December 19, 2022 23:44
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 86.58% // Head: 85.72% // Decreases project coverage by -0.85% ⚠️

Coverage data is based on head (9eedf97) compared to base (b6dccb3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02   #12423      +/-   ##
================================================
- Coverage         86.58%   85.72%   -0.86%     
================================================
  Files               155      155              
  Lines             24368    24793     +425     
================================================
+ Hits              21098    21254     +156     
- Misses             3270     3539     +269     
Impacted Files Coverage Δ
python/cudf/cudf/_version.py 1.41% <0.00%> (-98.59%) ⬇️
python/cudf/cudf/core/buffer/spill_manager.py 72.50% <0.00%> (-7.50%) ⬇️
python/cudf/cudf/core/buffer/spillable_buffer.py 90.04% <0.00%> (-2.81%) ⬇️
python/cudf/cudf/utils/dtypes.py 77.77% <0.00%> (-1.69%) ⬇️
python/cudf/cudf/options.py 86.11% <0.00%> (-1.59%) ⬇️
python/cudf/cudf/core/single_column_frame.py 94.30% <0.00%> (-1.27%) ⬇️
...ython/custreamz/custreamz/tests/test_dataframes.py 98.38% <0.00%> (-1.01%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.81% <0.00%> (-0.59%) ⬇️
python/cudf/cudf/core/multiindex.py 91.66% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/algorithms.py 90.00% <0.00%> (-0.48%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 450d684 into rapidsai:branch-23.02 Dec 20, 2022
@vyasr vyasr deleted the fix/xfail_incompatibility branch December 20, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants