Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conversion to/from cudf in dask.dataframe.core.to_backend #12380
Support conversion to/from cudf in dask.dataframe.core.to_backend #12380
Changes from 9 commits
fd190ab
29eb466
5df1191
b5b8337
ceff3e2
a995644
a08e7d1
7592fd5
0c6e8f1
6c72cb7
d685001
7916664
d89825e
351232b
ed04e3c
b0c0193
7624864
0242b5e
46a99cb
d56ff3f
e3239b0
1099f8b
7d10ccf
8f947b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is a question for the dask side of the implementation, but under what circumstances can
kwargs
be non-empty (and then relatedly, are there circumstances in which we already have a cudf-backed collection where non-empty kwargs could semantically require something different thandata.map_partitions(identity)
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - I updated things a bit to be explicit about supported/unsupported key-word arguments. I also added a bit more test coverage.
Context: We (probably) do want to make it possible to do things like
ddf.to_backend("cudf", nan_as_null=False)
. However, I'm still unsure of the best way to document the supportedto_backend
kwargs for the various conversions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, can we link to the registered backend dispatch function which could explain what it accepts as keyword arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll give this a think, but not sure how/where to link to the dispatch-function args, since the available arguments to the user-facing API (to_backend) will depend on the specified backend. Any ideas?