Rework nvtext::detokenize to use indexalator for row indices #12267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov ReportBase: 88.37% // Head: 88.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12267 +/- ##
================================================
- Coverage 88.37% 88.16% -0.21%
================================================
Files 137 137
Lines 22657 22665 +8
================================================
- Hits 20022 19982 -40
- Misses 2635 2683 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
added
3 - Ready for Review
ttnghia
reviewed
Dec 2, 2022
ttnghia
reviewed
Dec 2, 2022
ttnghia
approved these changes
Dec 5, 2022
karthikeyann
reviewed
Dec 6, 2022
bdice
approved these changes
Dec 6, 2022
cpp/src/text/detokenize.cu
Outdated
| cudf::size_type tokens_counts, | ||
| rmm::cuda_stream_view stream) | ||
| { | ||
| index_changed_fn pfn{cudf::detail::indexalator_factory::make_input_iterator(row_indices), |
There was a problem hiding this comment.
I don't know what pfn means. "P..." function?
There was a problem hiding this comment.
The 'p' is silent.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework
nvtext::detokenizeto use thecudf::detail::make_strings_childrenand thecudf::detail::indexalator.This allows the operation to throw an error if it the output would exceed the size limit of a column.
The indexalator usage removes the need for a type-dispatcher call for the row-indices.
No function has been added, removed, or changed.
Reference #12167
Checklist