Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default parameters from cudf::detail::sort function declarations #12254

Merged

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 29, 2022

Description

Removes the default parameter declarations from cudf::detail::sort, cudf::detail::sorted_order, cudf::detail::sort_by_key, cudf::detail::stable_sorted_order, and cudf::detail::stable_sort_by_key as well as cudf::detail::quantile, cudf::detail::quantiles and cudf::detail::percentile_approx
Reference comment: #12237 (comment)
Also fixes incorrect stream parameter passed within a quantiles.cu detail function.
No function has been added, modified, or changed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 29, 2022
@davidwendt davidwendt self-assigned this Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@715aa9a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02   #12254   +/-   ##
===============================================
  Coverage                ?   88.20%           
===============================================
  Files                   ?      137           
  Lines                   ?    22653           
  Branches                ?        0           
===============================================
  Hits                    ?    19981           
  Misses                  ?     2672           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 29, 2022
@davidwendt davidwendt marked this pull request as ready for review November 29, 2022 20:43
@davidwendt davidwendt requested a review from a team as a code owner November 29, 2022 20:43
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6af6563 into rapidsai:branch-23.02 Nov 30, 2022
@davidwendt davidwendt deleted the remove-detail-defparms-sort branch November 30, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants