-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix include line for IO Cython modules #12250
Conversation
How does this relate to the comment below? Does something else need changed/updated? cudf/python/cudf/cudf/_lib/CMakeLists.txt Lines 82 to 84 in 2a5411a
|
That comment is referring to the changes I made to |
Codecov ReportBase: 88.25% // Head: 88.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12250 +/- ##
=============================================
Coverage 88.25% 88.25%
=============================================
Files 137 137
Lines 22571 22571
=============================================
Hits 19921 19921
Misses 2650 2650 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
This PR ensures that numpy include directories are visible to the cuIO Cython TUs. #12096 changed the way that numpy was being found but did not update this line. The old variable is automatically being created by scikit-build's Python code, so as long as skbuild correctly finds the libraries the old variable still works, but we do not want to rely on that since it is not true in all environments.
Checklist