-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace column/table test utilities with macros #12242
Replace column/table test utilities with macros #12242
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12242 +/- ##
===============================================
Coverage ? 88.20%
===============================================
Files ? 137
Lines ? 22660
Branches ? 0
===============================================
Hits ? 19988
Misses ? 2672
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
@PointKernel Thank you for the cleanup. This cpp API usage still happens. |
I moved those utilities to
Good point. I will put up a PR updating docs and comments for this. |
Following rapidsai/cudf#12242, this PR updates libcuspatial tests with cudf test macros. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #841
w.r.t. #11007
This PR moves
cudf::test::expect_column/table*
utilities to thedetail
namespace and replace their use cases with corresponding macros when possible.Description
Checklist