Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cudf::strings::pad and zfill to use make_strings_children #12238

Merged

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 23, 2022

Description

Rework cudf::strings::pad and cudf::strings::zfill to use the internal make_strings_children. This simplifies the code and allows the operation to throw an error if it the output would exceed the size limit of a column.
No function has been added, removed, or changed.

Reference #12167

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 23, 2022
@davidwendt davidwendt self-assigned this Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@9af3ed8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02   #12238   +/-   ##
===============================================
  Coverage                ?   88.20%           
===============================================
  Files                   ?      137           
  Lines                   ?    22660           
  Branches                ?        0           
===============================================
  Hits                    ?    19988           
  Misses                  ?     2672           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 28, 2022
@davidwendt davidwendt marked this pull request as ready for review November 29, 2022 15:26
@davidwendt davidwendt requested a review from a team as a code owner November 29, 2022 15:26
cpp/src/strings/padding.cu Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8e0ee53 into rapidsai:branch-23.02 Dec 1, 2022
@davidwendt davidwendt deleted the pad-make-strings-children branch December 1, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants