-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework cudf::strings::pad and zfill to use make_strings_children #12238
Merged
rapids-bot
merged 8 commits into
rapidsai:branch-23.02
from
davidwendt:pad-make-strings-children
Dec 1, 2022
Merged
Rework cudf::strings::pad and zfill to use make_strings_children #12238
rapids-bot
merged 8 commits into
rapidsai:branch-23.02
from
davidwendt:pad-make-strings-children
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
strings
strings issues (C++ and Python)
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 23, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12238 +/- ##
===============================================
Coverage ? 88.20%
===============================================
Files ? 137
Lines ? 22660
Branches ? 0
===============================================
Hits ? 19988
Misses ? 2672
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Nov 28, 2022
ttnghia
reviewed
Nov 29, 2022
ttnghia
reviewed
Nov 29, 2022
ttnghia
approved these changes
Nov 29, 2022
mythrocks
approved these changes
Nov 30, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework
cudf::strings::pad
andcudf::strings::zfill
to use the internalmake_strings_children
. This simplifies the code and allows the operation to throw an error if it the output would exceed the size limit of a column.No function has been added, removed, or changed.
Reference #12167
Checklist