Add notebook dependency to testing_py35.yml #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master 8776841, the conda environment in
notebook_py35.yml
is broken, giving error messages similar to #101 and #117. I believe this is due to https://github.com/gpuopenanalytics/pygdf/blob/master/conda_environments/notebook_py35.yml#L84-L85 having outdated version libraries.For maintainability, it seems like bundling Jupyter notebook within the
pygdf_dev
environment makes more sense, and then two .yml files don't need to be maintained. I labeled this PR as [WIP] because I didn't want to delete thenotebook_py35.yml
file in case someone thinks it should stay, but if everyone agrees I can push another commit to removenotebook_py35.yml
.