Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of tests marked spilling #12197

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Nov 18, 2022

To save CI running time, this PR reduce the tests marked spilling drastically.

An alternative to #12187

@github-actions github-actions bot added Python Affects Python cuDF API. gpuCI labels Nov 18, 2022
@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 87.47% // Head: 88.25% // Increases project coverage by +0.78% 🎉

Coverage data is based on head (fb32d69) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12197      +/-   ##
================================================
+ Coverage         87.47%   88.25%   +0.78%     
================================================
  Files               133      137       +4     
  Lines             21826    22571     +745     
================================================
+ Hits              19093    19921     +828     
+ Misses             2733     2650      -83     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/strings_udf/strings_udf/__init__.py 75.80% <0.00%> (-8.51%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madsbk madsbk force-pushed the reduce_tests_marked_spilling branch from 43bc44b to fb32d69 Compare November 18, 2022 13:30
@github-actions github-actions bot removed the gpuCI label Nov 18, 2022
@madsbk madsbk marked this pull request as ready for review November 18, 2022 13:37
@madsbk madsbk requested a review from a team as a code owner November 18, 2022 13:37
@madsbk madsbk requested review from mroeschke and isVoid November 18, 2022 13:37
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Nov 18, 2022
@galipremsagar galipremsagar mentioned this pull request Nov 18, 2022
3 tasks
@ajschmidt8 ajschmidt8 changed the title Reduce number of tests marked spilling Reduce number of tests marked spilling Nov 18, 2022
@ajschmidt8 ajschmidt8 merged commit a2f69e4 into rapidsai:branch-22.12 Nov 18, 2022
@madsbk madsbk deleted the reduce_tests_marked_spilling branch November 21, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants