Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use CMake 3.25.0 as it has a show stopping FindCUDAToolkit bug #12188

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

Don't use CMake 3.25.0 as it has a show stopping FindCUDAToolkit bug

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change labels Nov 17, 2022
@robertmaynard robertmaynard requested review from a team as code owners November 17, 2022 19:19
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Nov 17, 2022
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @robertmaynard !

@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 17, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@vyasr
Copy link
Contributor

vyasr commented Nov 18, 2022

rerun tests

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 88.23% // Head: 88.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (70c8b9b) compared to base (aa13b95).
Patch coverage: 63.15% of modified lines in pull request are covered.

❗ Current head 70c8b9b differs from pull request most recent head 322ebb9. Consider uploading reports for the commit 322ebb9 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.12   #12188   +/-   ##
=============================================
  Coverage         88.23%   88.24%           
=============================================
  Files               137      137           
  Lines             22553    22571   +18     
=============================================
+ Hits              19899    19917   +18     
  Misses             2654     2654           
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 69.35% <36.36%> (-7.12%) ⬇️
python/cudf/cudf/core/udf/__init__.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.64% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.65% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.51% <0.00%> (+0.20%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/decimal.py 91.89% <0.00%> (+0.54%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit cc4b4dd into rapidsai:branch-22.12 Nov 18, 2022
@robertmaynard robertmaynard deleted the bug/avoid_cmake_3.25.0 branch November 18, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants