-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data corruption when reading ORC files with empty stripes #12160
Fix data corruption when reading ORC files with empty stripes #12160
Conversation
Codecov ReportBase: 88.25% // Head: 88.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12160 +/- ##
=============================================
Coverage 88.25% 88.25%
=============================================
Files 137 137
Lines 22571 22571
=============================================
Hits 19921 19921
Misses 2650 2650
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This fixes the one file I uploaded, but it does not work when there are other stripes in the file that do have data. I'll see if I can come up with a synthetic file that shows this same issue. |
combined_error.zip holds an ORC file that has more rows in it and still is showing the problem that we had, and fits more with what our customer is actually seeing. |
…bug-read_orc-empty-map-column
…bug-read_orc-empty-map-column
…bug-read_orc-empty-map-column
…bug-read_orc-empty-map-column
Description
Closes #12155
Closes #12156
Two fixes:
Checklist