-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JNI] Adds an EventHandler to Java MemoryBuffer to be invoked on close #12125
[JNI] Adds an EventHandler to Java MemoryBuffer to be invoked on close #12125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lgtm
Should we start exploring Java Instrumentation API such that we can keep auxiliary monitoring code out the production codebase similar to CUPTI |
In this scenario this is production code. We expect to use this in the spill framework. |
Codecov ReportBase: 87.47% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12125 +/- ##
================================================
+ Coverage 87.47% 88.11% +0.63%
================================================
Files 133 135 +2
Lines 21826 22100 +274
================================================
+ Hits 19093 19473 +380
+ Misses 2733 2627 -106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
This PR adds an EventHandler to
MemoryBuffer
with a single methodonClosed
. This is invoked during theclose
call, but after therefCount
has been updated.I am also making
getRefCount
public in this PR. Spill code in the RAPIDS Accelerator for Spark could likely assert/require that refCount==1 when taking in a new buffer to be spillable. This last change is a nice to have.