-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex working-memory-size refactor error #12119
Fix regex working-memory-size refactor error #12119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround, @davidwendt! This fixes the recent regex-related test failures in the RAPIDS Accelerator for Apache Spark.
Codecov ReportBase: 87.47% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12119 +/- ##
================================================
+ Coverage 87.47% 88.11% +0.63%
================================================
Files 133 135 +2
Lines 21826 22100 +274
================================================
+ Hits 19093 19473 +380
+ Misses 2733 2627 -106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
Fixes error in
working_memory_size()
member function passing the parameters incorrectly.This was introduce in #11927 and found in the nightly compute-sanitizer check.
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/branches/job/cudf-gpu-build-branch-22.12/19/CUDA=11.5/testReport/junit/cudamemcheck/STRINGS_TEST/StringsContainsTests_ContainsTest/
Checklist