-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support +
in strings_udf
#12117
Support +
in strings_udf
#12117
Conversation
Note for reviewers: one might ask themselves, where is the lowering for this operator for |
rerun tests |
Codecov ReportBase: 87.47% // Head: 88.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12117 +/- ##
================================================
+ Coverage 87.47% 88.13% +0.65%
================================================
Files 133 135 +2
Lines 21826 22144 +318
================================================
+ Hits 19093 19516 +423
+ Misses 2733 2628 -105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving C++ code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python LGTM. Possibly needs another test but I'll let you make that call.
@gpucibot merge |
This PR adds support for the following operator
strings_udf
:st + other
Part of #9639