Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support + in strings_udf #12117

Merged

Conversation

brandon-b-miller
Copy link
Contributor

This PR adds support for the following operator strings_udf:

  • st + other

Part of #9639

@brandon-b-miller brandon-b-miller added feature request New feature or request 2 - In Progress Currently a work in progress numba Numba issue Python Affects Python cuDF API. non-breaking Non-breaking change labels Nov 10, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner November 10, 2022 16:07
@brandon-b-miller brandon-b-miller self-assigned this Nov 10, 2022
@brandon-b-miller
Copy link
Contributor Author

brandon-b-miller commented Nov 10, 2022

Note for reviewers: one might ask themselves, where is the lowering for this operator for MaskedType? and how does it work without it? Well, + is part of our binary_ops and in our normal lowering for MaskedType within masked_lowering.py, + is already registered between instances of MaskedType. Numba hooks into this lowering, and then ends up finding the + operator already registered between the two .value_types and just calls that. So, no need for explicit lowering for concat between MaskedTypes here.

@brandon-b-miller
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 87.47% // Head: 88.13% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (d6d030c) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12117      +/-   ##
================================================
+ Coverage         87.47%   88.13%   +0.65%     
================================================
  Files               133      135       +2     
  Lines             21826    22144     +318     
================================================
+ Hits              19093    19516     +423     
+ Misses             2733     2628     -105     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 76.47% <0.00%> (-7.85%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++ code.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python LGTM. Possibly needs another test but I'll let you make that call.

@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 742093e into rapidsai:branch-22.12 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants