-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] First pass of pd.read_orc
changes in tests
#12103
Conversation
read_orc
changes in testspd.read_orc
changes in tests
Codecov ReportBase: 87.47% // Head: 88.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12103 +/- ##
================================================
+ Coverage 87.47% 88.08% +0.60%
================================================
Files 133 135 +2
Lines 21826 22100 +274
================================================
+ Hits 19093 19466 +373
+ Misses 2733 2634 -99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the change!
Can we expect noticeably lower test execution time with this change? I don't have a good sense of how efficient the conversion is(was).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! My only comment is whether we need to support pandas pre 1.0 at all?
Good catch. Rapids only support pandas >=1.0, so dropped the pre 1.0 code. |
@gpucibot merge |
Description
This PR changes calls going via
pyarrow
and thento_pandas
to directly callpd.read_orc
. How-ever sincepd.read_orc
was added in pandas 1.0, we will need to version the call to this constructor. This PR does that.Partially contributes to #11540
Checklist