-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _label_encoding
from Series to Column
#12040
Move _label_encoding
from Series to Column
#12040
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12040 +/- ##
===============================================
Coverage ? 88.19%
===============================================
Files ? 137
Lines ? 22684
Branches ? 0
===============================================
Hits ? 20007
Misses ? 2677
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it looks like we can't actually remove the method. Should we rename it to more accurately reflect its current role rather than the name of the former public API that it reflects (I don't have any ideas, asking in case you do).
@gpucibot merge |
Maybe closes #9474.
The
Series._label_encoding
function is used to integer encode columns. It makes much more sense for this to be a method ofColumn
rather thanSeries
(the index is irrelevant). Thus, I've moved the implementation toColumn
,