Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _label_encoding from Series to Column #12040

Merged
merged 7 commits into from
Nov 30, 2022

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Nov 1, 2022

Maybe closes #9474.

The Series._label_encoding function is used to integer encode columns. It makes much more sense for this to be a method of Column rather than Series (the index is irrelevant). Thus, I've moved the implementation to Column,

@shwina shwina requested a review from a team as a code owner November 1, 2022 18:23
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@5f83a84). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 263c4d5 differs from pull request most recent head 710c6f6. Consider uploading reports for the commit 710c6f6 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02   #12040   +/-   ##
===============================================
  Coverage                ?   88.19%           
===============================================
  Files                   ?      137           
  Lines                   ?    22684           
  Branches                ?        0           
===============================================
  Hits                    ?    20007           
  Misses                  ?     2677           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it looks like we can't actually remove the method. Should we rename it to more accurately reflect its current role rather than the name of the former public API that it reflects (I don't have any ideas, asking in case you do).

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@shwina shwina changed the base branch from branch-22.12 to branch-23.02 November 23, 2022 13:23
@vyasr vyasr added tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 29, 2022
@vyasr
Copy link
Contributor

vyasr commented Nov 30, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cb8d9e1 into rapidsai:branch-23.02 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf uses deprecated Series.label_encoding function internally
2 participants