Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building against the libarrow contained in pyarrow #12034

Merged
merged 22 commits into from
Nov 8, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 1, 2022

Description

This feature is a prerequisite for wheels. There is no real good reason to do this except to provide interop with a pyarrow wheel, so this option is marked as advanced. In the process of implementing this feature, I have also done some cleanup of get_arrow.cmake to try and simplify its logic.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels Nov 1, 2022
@vyasr vyasr self-assigned this Nov 1, 2022
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Nov 1, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Nov 1, 2022

@robertmaynard @trxcllnt I'd appreciate some feedback from you two on the various TODO comments that I added to get_arrow.cmake to help figure out what we can do to simplify the logic there. I'm not sure how much of the complexity is unavoidable and how much we could simplify.

cpp/src/interop/to_arrow.cu Outdated Show resolved Hide resolved
@vyasr vyasr marked this pull request as ready for review November 1, 2022 22:21
@vyasr vyasr requested a review from a team as a code owner November 1, 2022 22:21
@vyasr vyasr requested a review from a team as a code owner November 1, 2022 22:21
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
Copy link
Contributor Author

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard I left comments to help clarify exactly where I think there are still open questions that I could use some help with.

cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
python/cudf/CMakeLists.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 87.47% // Head: 88.10% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (cfd45ed) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12034      +/-   ##
================================================
+ Coverage         87.47%   88.10%   +0.62%     
================================================
  Files               133      135       +2     
  Lines             21826    22057     +231     
================================================
+ Hits              19093    19433     +340     
+ Misses             2733     2624     -109     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr requested a review from robertmaynard November 8, 2022 19:06
@vyasr
Copy link
Contributor Author

vyasr commented Nov 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8ee5f51 into rapidsai:branch-22.12 Nov 8, 2022
@vyasr vyasr deleted the feature/build_pip_arrow branch November 8, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants