-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building against the libarrow contained in pyarrow #12034
Enable building against the libarrow contained in pyarrow #12034
Conversation
… up some comments." This reverts commit b9d4c7b.
@robertmaynard @trxcllnt I'd appreciate some feedback from you two on the various TODO comments that I added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertmaynard I left comments to help clarify exactly where I think there are still open questions that I could use some help with.
Codecov ReportBase: 87.47% // Head: 88.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12034 +/- ##
================================================
+ Coverage 87.47% 88.10% +0.62%
================================================
Files 133 135 +2
Lines 21826 22057 +231
================================================
+ Hits 19093 19433 +340
+ Misses 2733 2624 -109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…w extraneous setting of compile options.
@gpucibot merge |
Description
This feature is a prerequisite for wheels. There is no real good reason to do this except to provide interop with a pyarrow wheel, so this option is marked as advanced. In the process of implementing this feature, I have also done some cleanup of
get_arrow.cmake
to try and simplify its logic.Checklist