Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add memory_usage & items implementation for Struct column & dtype #12033

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #11893

  • This PR implements StructColumn.memory_usage and StructDtype.items

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Oct 31, 2022
@galipremsagar galipremsagar self-assigned this Oct 31, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner October 31, 2022 23:29
@galipremsagar galipremsagar requested a review from shwina October 31, 2022 23:29
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 31, 2022
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for memory usage before after nullable?

python/cudf/cudf/tests/test_struct.py Show resolved Hide resolved
python/cudf/cudf/core/column/struct.py Show resolved Hide resolved
python/cudf/cudf/core/dtypes.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from wence- November 1, 2022 12:41
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 88.09% // Head: 86.88% // Decreases project coverage by -1.21% ⚠️

Coverage data is based on head (c935da5) compared to base (f0b4c4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c935da5 differs from pull request most recent head 668c842. Consider uploading reports for the commit 668c842 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12033      +/-   ##
================================================
- Coverage         88.09%   86.88%   -1.22%     
================================================
  Files               133      133              
  Lines             21982    21995      +13     
================================================
- Hits              19366    19111     -255     
- Misses             2616     2884     +268     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/struct.py 96.47% <100.00%> (+0.41%) ⬆️
python/cudf/cudf/core/dtypes.py 96.67% <100.00%> (+0.03%) ⬆️
python/cudf/cudf/core/udf/strings_lowering.py 0.00% <0.00%> (-100.00%) ⬇️
python/cudf/cudf/core/udf/strings_typing.py 0.00% <0.00%> (-95.78%) ⬇️
python/strings_udf/strings_udf/lowering.py 0.00% <0.00%> (-84.40%) ⬇️
python/cudf/cudf/core/udf/__init__.py 50.00% <0.00%> (-47.06%) ⬇️
python/strings_udf/strings_udf/_typing.py 81.05% <0.00%> (-13.69%) ⬇️
python/cudf/cudf/core/udf/utils.py 97.00% <0.00%> (-2.00%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 3, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b156c25 into rapidsai:branch-22.12 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame.info() on list of structs throws error
2 participants