-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add memory_usage
& items
implementation for Struct
column & dtype
#12033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for memory usage before after nullable?
Codecov ReportBase: 88.09% // Head: 86.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12033 +/- ##
================================================
- Coverage 88.09% 86.88% -1.22%
================================================
Files 133 133
Lines 21982 21995 +13
================================================
- Hits 19366 19111 -255
- Misses 2616 2884 +268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@gpucibot merge |
Description
Fixes: #11893
StructColumn.memory_usage
andStructDtype.items
Checklist