Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cython-lint to pre-commit checks. #12020

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 28, 2022

Description

Adds cython-lint (https://github.com/MarcoGorelli/cython-lint) to the list of pre-commit checks. It is most similar to flake8 but with support for Cython syntax -- the rule set it enforces is fairly short, it mostly helps identify unused imports in Cython files.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Oct 28, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 28, 2022
@bdice bdice added code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 88.15% // Head: 86.88% // Decreases project coverage by -1.26% ⚠️

Coverage data is based on head (92a5c09) compared to base (69fac8a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12020      +/-   ##
================================================
- Coverage         88.15%   86.88%   -1.27%     
================================================
  Files               133      133              
  Lines             22148    21973     -175     
================================================
- Hits              19525    19092     -433     
- Misses             2623     2881     +258     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/strings_lowering.py 0.00% <0.00%> (-100.00%) ⬇️
python/cudf/cudf/core/udf/strings_typing.py 0.00% <0.00%> (-95.78%) ⬇️
python/strings_udf/strings_udf/lowering.py 0.00% <0.00%> (-84.40%) ⬇️
python/cudf/cudf/core/udf/__init__.py 50.00% <0.00%> (-47.06%) ⬇️
python/strings_udf/strings_udf/_typing.py 81.05% <0.00%> (-13.69%) ⬇️
python/cudf/cudf/core/udf/utils.py 97.00% <0.00%> (-2.00%) ⬇️
python/cudf/cudf/core/dataframe.py 93.70% <0.00%> (-0.05%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice marked this pull request as ready for review October 28, 2022 17:19
@bdice bdice requested a review from a team as a code owner October 28, 2022 17:19
@bdice
Copy link
Contributor Author

bdice commented Oct 28, 2022

@MarcoGorelli Thanks for your work on cython-lint! I opened this PR to add cython-lint to our pre-commit checks. Since this build passed CI, I think the potential bug we discussed in #11684 has been fixed!

@MarcoGorelli
Copy link
Contributor

I think the potential bug we discussed in #11684 has been fixed!

Cool, thanks for the update, and please do reach out if anything else comes up!

@bdice
Copy link
Contributor Author

bdice commented Oct 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0603167 into rapidsai:branch-22.12 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants