Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused managed_allocator #12005

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 26, 2022

Description

The managed_allocator class is not used anywhere. All uses of cuco maps or the concurrent_unordered_map just use the default_allocator.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function breaking Breaking change labels Oct 26, 2022
@vyasr vyasr requested a review from a team as a code owner October 26, 2022 19:27
@vyasr vyasr self-assigned this Oct 26, 2022
@vyasr vyasr requested review from cwharris and nvdbaranec October 26, 2022 19:27
@vyasr
Copy link
Contributor Author

vyasr commented Oct 26, 2022

CC @PointKernel @bdice

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I saw this recently and agree with its removal. I checked broadly for any uses in other packages -- this is dead code.

@vyasr
Copy link
Contributor Author

vyasr commented Oct 26, 2022

rerun tests

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Oct 27, 2022

rerun tests

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 87.40% // Head: 86.90% // Decreases project coverage by -0.50% ⚠️

Coverage data is based on head (5de1a06) compared to base (f72c4ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12005      +/-   ##
================================================
- Coverage         87.40%   86.90%   -0.51%     
================================================
  Files               133      133              
  Lines             21833    21977     +144     
================================================
+ Hits              19084    19099      +15     
- Misses             2749     2878     +129     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/lowering.py 0.00% <0.00%> (-84.40%) ⬇️
python/strings_udf/strings_udf/_typing.py 81.05% <0.00%> (-14.74%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (-12.57%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 82.20% <0.00%> (-3.35%) ⬇️
python/cudf/cudf/core/column/lists.py 92.78% <0.00%> (-0.97%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 84.19% <0.00%> (-0.31%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice
Copy link
Contributor

bdice commented Oct 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 69fac8a into rapidsai:branch-22.12 Oct 27, 2022
@vyasr vyasr deleted the refactor/remove_managed_allocator branch January 23, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants