-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused managed_allocator
#12005
Remove unused managed_allocator
#12005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I saw this recently and agree with its removal. I checked broadly for any uses in other packages -- this is dead code.
rerun tests |
1 similar comment
rerun tests |
Codecov ReportBase: 87.40% // Head: 86.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12005 +/- ##
================================================
- Coverage 87.40% 86.90% -0.51%
================================================
Files 133 133
Lines 21833 21977 +144
================================================
+ Hits 19084 19099 +15
- Misses 2749 2878 +129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
The
managed_allocator
class is not used anywhere. All uses of cuco maps or theconcurrent_unordered_map
just use thedefault_allocator
.Checklist