Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions Workflows #12002

Merged
merged 119 commits into from
Dec 2, 2022
Merged

Add GitHub Actions Workflows #12002

merged 119 commits into from
Dec 2, 2022

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Oct 26, 2022 •
edited
Loading

Description

This PR adds GitHub Actions workflows to cudf.

Task list

Coverage required for this PR:

  • C++ tests
  • Python tests for cudf (first success: c3bdbce)
  • Python tests for custreamz, cudf_kafka
  • Java tests
  • Check dask configuration
  • strings_udf
  • Benchmarks
  • Notebooks
  • Codecov
  • Enable style checks script (ci/check_style.sh)
  • Consolidate existing checks job into the pr.yaml workflow in this PR.

Future PRs:

  • Build Metrics Report
  • libidentify_stream_usage
  • JUnit output annotations? https://github.com/marketplace/actions/junit-report-action
  • Reduce exit code handling verbosity (use global variable with trap function)
  • Setup rapids-dependency-file-generator pre-commit hook (also setup for others repos: rmm, rapids-cmake, cuspatial, etc.)
  • Docs builds

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 26, 2022
@ajschmidt8 ajschmidt8 mentioned this pull request Oct 26, 2022
Closed
@ajschmidt8
Copy link
Member Author

ajschmidt8 commented Nov 9, 2022 •
edited by bdice
Loading

Adding a note so that we don't forget to include these items in this PR:

galipremsagar
galipremsagar approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dask pinnings looks good to me 👍

@ajschmidt8 ajschmidt8 marked this pull request as ready for review December 1, 2022 15:34
@ajschmidt8 ajschmidt8 requested review from a team as code owners December 1, 2022 15:34
@ajschmidt8 ajschmidt8 changed the title [skip gpuci] Add GitHub Actions Workflows Add GitHub Actions Workflows Dec 1, 2022
@ajschmidt8
Copy link
Member Author

rerun tests

@ttnghia ttnghia mentioned this pull request Dec 1, 2022
Open
bdice
bdice reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor edits.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
ci/test_cpp.sh Show resolved Hide resolved
conda/recipes/cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/cudf_kafka/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/custreamz/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libcudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/strings_udf/meta.yaml Outdated Show resolved Hide resolved
jjacobelli
jjacobelli approved these changes Dec 1, 2022
View reviewed changes
ci/test_notebooks.sh Show resolved Hide resolved
bdice
bdice reviewed Dec 1, 2022
View reviewed changes
conda/recipes/strings_udf/meta.yaml Outdated
imports: # [linux64]
- strings_udf # [linux64]
- ptxcompiler >=0.7.0 # CUDA enhanced compatibility. See https://github.com/rapidsai/ptxcompiler
test:
Copy link
Contributor

@bdice bdice Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing on ARM + gpuCI Jenkins. We probably can't remove the # [linux64] on the test: portion until Jenkins is disabled. This appears to work fine on GitHub Actions for whatever reason.

@ajschmidt8 ajschmidt8 merged commit 2bba970 into rapidsai:branch-23.02 Dec 2, 2022
@ajschmidt8 ajschmidt8 deleted the gha branch December 2, 2022 15:20
@ajschmidt8 ajschmidt8 mentioned this pull request Dec 2, 2022
Merged
3 tasks
ajschmidt8 added a commit that referenced this pull request Dec 2, 2022
@ajschmidt8
Re-enable sccache for Jenkins builds (#12297)
9682fca 
This PR re-adds some environment variables to the Jenkins scripts that are missing from the Jenkins CI images in order to re-enable `sccache`. These were accidentally removed in #12002.

All of these Jenkins scripts will be removed once Jenkins is disabled.

Authors:
   - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
   - Bradley Dice (https://github.com/bdice)
   - Mark Sadang (https://github.com/msadang)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ajschmidt8 @bdice @vyasr @ttnghia @jjacobelli @galipremsagar